m -j32 iso_img(

​

Submitter

	​​Wolfram Sang​​
Date	June 6, 2016, 7 p.m.
Message ID	<[e-mail]>
Download	​​mbox​​| ​​patch​​
Permalink	​​/patch/9159023/​​
State	New
Headers	show

Comments

​​Wolfram Sang​​ - June 6, 2016, 7 p.m.

I tried to use 'make O=...' from an unclean source tree. This triggered
the error path of setlocalversion. But by printing to STDOUT, it created
a broken localversion which then caused another (unrelated) error:

"4.7.0-rc2Error: kernelrelease not valid - run make prepare to update it" exceeds 64 characters

After printing to STDERR, the true build error gets displayed later:

  /home/wsa/Kernel/linux is not clean, please run 'make mrproper'
  in the '/home/wsa/Kernel/linux' directory.

Signed-off-by: Wolfram Sang <[e-mail]>
---
 scripts/setlocalversion | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

​​Michal Marek​​ - June 20, 2016, 3:38 p.m.

On Mon, Jun 06, 2016 at 09:00:38PM +0200, Wolfram Sang wrote:
> I tried to use 'make O=...' from an unclean source tree. This triggered
> the error path of setlocalversion. But by printing to STDOUT, it created
> a broken localversion which then caused another (unrelated) error:
> 
> "4.7.0-rc2Error: kernelrelease not valid - run make prepare to update it" exceeds 64 characters
> 
> After printing to STDERR, the true build error gets displayed later:
> 
>   /home/wsa/Kernel/linux is not clean, please run 'make mrproper'
>   in the '/home/wsa/Kernel/linux' directory.
> 
> Signed-off-by: Wolfram Sang <[e-mail]>
> ---
>  scripts/setlocalversion | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, applied to kbuild.git#kbuild. But this points at another
problem, namely that filechk is ignoring the exit status of the command.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/scripts/setlocalversion b/scripts/setlocalversion
index 63d91e22ed7ccd..966dd3924ea9cb 100755
--- a/scripts/setlocalversion
+++ b/scripts/setlocalversion
@@ -143,7 +143,7 @@  fi
 if test -e include/config/auto.conf; then
  . include/config/auto.conf
 else
- echo "Error: kernelrelease not valid - run 'make prepare' to update it"
+ echo "Error: kernelrelease not valid - run 'make prepare' to update it" >&2
  exit 1
 fi